[openSUSE] upstream defaults for systemd-presets are ignored

[FroggyFlox]

We currently use a dedicated systemd-presets file (https://github.com/rockstor/rockstor-core/blob/master/conf/90-default.preset) in the high priority location /etc/systemd/system-preset/ to define defaults enabled/disabled state for all systemd services.

Notably, this file ends with disable *, which sets a default disabled state for all services not defined in this file, and thus bypasses all defaults defined by upstream.

As the openSUSE wiki reads:
https://en.opensuse.org/openSUSE:Systemd_packaging_guidelines#Enabling_systemd_unit_files

systemd-presets-common-SUSE is intended for services that are mandatory for a proper function of the system or the package. Placing preset into this file means: All systems should use this value as a default. This package is a common base for both open and enterprise products and it is part of all base installations.

systemd-presets-branding-openSUSE is indented for vendor customization. Placing a preset here means: It is a wise default for openSUSE, but not enabling this service in other product makes perfect sense. The package structure makes possible to create a custom brand with a custom systemd-presets-branding-brand as a part of custom branding. Generic rules for branding packages are explained in openSUSE:Packaging_Branding.

Based on this, it would seem the recommended way would be to use our own systemd-presets-branding-rockstor package instead.

[phillxnet]

@FroggyFlox Agreed. Thanks for the exposition and the reference links.
Copying in the "openSUSE:Packaging_Branding" link referenced in your quote for reference:
https://en.opensuse.org/openSUSE:Packaging_Branding