Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .beeshome to the list of ignored subvolumes #2223

Closed
ubenmackin opened this issue Oct 2, 2020 · 2 comments · Fixed by #2270
Closed

Add .beeshome to the list of ignored subvolumes #2223

ubenmackin opened this issue Oct 2, 2020 · 2 comments · Fixed by #2270
Assignees

Comments

@ubenmackin
Copy link
Contributor

See discussion here:

https://forum.rockstor.com/t/bees-beeshome-subvolume-getting-remounted-by-rockstor/7355/2

The gist is that I am requesting that .beeshome be added to the list of ignored subvolumes.

@phillxnet phillxnet added this to the First 4 Stable (ISO) milestone Jan 23, 2021
@phillxnet phillxnet self-assigned this Jan 24, 2021
@phillxnet
Copy link
Member

I am currently working on this issue.

Given we are likely to encounter other uses for a system-wide subvolume exclusion mechanism I'll use this issue to add a generic hard-wired system such as we already have for our system pool, but for all pools. Our existing system pool subvol blacklist is intended to mask subvols associated with a default openSUSE Leap install, such as for example the /var subvol. Where as I see the required mechanism here as one that might be used to mask 'after market'/non-native subvols, such as the indicated ".beeshome" one.

This subvol exclusion mechanism is important as a means by which we can remove incompatibilities that might otherwise hinder or break Rockstor's presentation of the imported pool states. Given non native subvols may well not comply to Rockstor's own expected subvol hierarchy/placement.

@phillxnet
Copy link
Member

Linking for context with the prior root only subvol exclusion issue:
"add root subvol exclusion mechanism" #1931
and the associated pull request:
"add root subvol exclusion mechanism. Fixes #1931" #1935

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jan 29, 2021
Adds an additional hard coded subvolume exclusion list, akin to the
existing system drive only one. All subvolume matches, by name, to list
members are ignored. List pre-populated by ".beeshome" and it's possible
boot-to-snapshot counterpart "@/.beeshome".

Includes a unit test mocking a typical data drive including the target
".beeshome" subvolume to prove the exclusion mechanisms function.
phillxnet added a commit that referenced this issue Jan 30, 2021
…e_exclusion_mechanism

Add system-wide subvol exclusion mechanism (#2223)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants