Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase minimum recognised disk size to 5GB and define at run-time #2308

Closed
phillxnet opened this issue Jul 28, 2021 · 3 comments
Closed

Increase minimum recognised disk size to 5GB and define at run-time #2308

phillxnet opened this issue Jul 28, 2021 · 3 comments
Assignees
@phillxnet

Comments

@phillxnet
Copy link
Member

In a number of trials with btrfs, especially during raid changes, it was found that a practical minimum to allow for basic experimentation was 5GB. Currently we ignore all devices below 1 GB: see MIN_DISK_SIZE in settings.conf.in. It is further proposed that we move this specification from being defined at build-time to being instantiated at run time. This way if a need arises folks can more easily adjust to their requirements, avoiding the need to rebuild in the process.

This change should help inexperienced users avoid experimenting with impractically small 'test' drives within VM setups for example and encountering self imposed instabilities due to extremely low chunk count.

For a similar proposal re moving from build-time to run-time definitions, initiated by @FroggyFlox, see the following comment:
#2303 (comment)
@phillxnet
Copy link
Member Author

See the following related issue re reducing our currently overly complex and imposing build system and moving another build-time setting to run-time:

Define Rock-ons default url at run-time not build-time #2358

@phillxnet phillxnet self-assigned this Mar 9, 2022
@phillxnet
Copy link
Member Author

I am currently working on this issue. I intend to use it as an initially trivial change to test our new testing/master branch split arrangement for testing and stable update channels so that we can, with as little disruption as possible, tackle our technical debt.

@phillxnet phillxnet mentioned this issue Mar 9, 2022
Closed
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Mar 9, 2022
@phillxnet
Increase minimum disk size to 5GiB and define at run-time rockstor#2308
1681095 
In a number of trials with btrfs, especially during raid changes, it was
found that a practical minimum to allow for basic experimentation was
5GiB. Currently we ignore all devices below 1 GiB.

This change increases our 'ignore devices below size' to 5 GiB.

Includes:
- Moving this definition away from build-time Django settings to plain
run-time: allowing for user modification if need be.
- Explanatory code comments and upstream btrfs wiki references.
- Note/reference on recommended non mixed mode minimum size as 16 GiB+.
@phillxnet phillxnet mentioned this issue Mar 9, 2022
Merged
phillxnet added a commit that referenced this issue Apr 7, 2022
@phillxnet
Merge pull request #2360 from phillxnet/2308_Increase_minimum_recogni…
83be5bf 
…sed_disk_size_to_5GB_and_define_at_run-time

Increase minimum disk size to 5 GiB and define at run-time #2308
@phillxnet
Copy link
Member Author

Closed by #2360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phillxnet