Increase minimum disk size to 5 GiB and define at run-time #2308 #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a number of trials with btrfs, especially during raid changes, it was found that a practical minimum to allow for basic experimentation was 5GiB. Currently we ignore all devices below 1 GiB. This change increases our 'ignore devices below size' to 5 GiB. Includes: - Moving this definition away from build-time Django settings to plain run-time: allowing for user modification if need be. - Explanatory code comments and upstream btrfs wiki references. - Note/reference on recommended non mixed mode minimum size as 16 GiB+.
phillxnet
changed the title
|
Tested to successfully ignore a 4 GB volume from the Web-UI that was otherwise attached as normal. |
phillxnet
deleted the
2308_Increase_minimum_recognised_disk_size_to_5GB_and_define_at_run-time
branch
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a number of trials with btrfs, especially during raid changes, it was found that a practical minimum to allow for basic experimentation was 5GiB. Currently we ignore all devices below 1 GiB.
Fixes #2308
@FroggyFlox I'm applying this one to testing as a proof of concept to kick off our new testing branch and to help test modification required to our production back-end.
This change increases our 'ignore devices below size' to 5 GiB.
Includes: