Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise draconian raid0 disk removal restriction #2385

Closed
phillxnet opened this issue Jun 28, 2022 · 2 comments
Closed

Revise draconian raid0 disk removal restriction #2385

phillxnet opened this issue Jun 28, 2022 · 2 comments
Milestone
First Stable Poet...

Comments

@phillxnet
Copy link
Member

phillxnet commented Jun 28, 2022 •
edited
Loading

While working on #2384, which has inevitably involved overhauling some of our outdated tests, it came to light that we block all disk removal from a raid0 pool. This is likely down to an early development-based fencing that has inadvertently remained. We have had the same for btrfs-single but this has since been removed (although it too had some legacy test content).

It is proposed that we move our absolute block on disk removal for btrfs-raid0 pools to have the same minimum disk restriction already imposed on btrfs-raid1 pools: i.e. don't go below 2 disks. Size/usage constrains for disk removal are already in place for all raid levels.

As this measure affects critical path functions it is proposed for testing branch (update channel) only.
@phillxnet
Copy link
Member Author

Noting this issue should only be attended too once we have #2384 resolved as we will then have a more robust testing setup to prove our proposed more flexible fencing on the raid0 front.

@phillxnet phillxnet added this to the First Stable Poetry build milestone Jan 17, 2023
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Feb 23, 2023
@phillxnet
Remove raid0 dev restriction & tidy pool dev fencing code rockstor#2385
d11c996 
We previously blocked raid0 disk removal outright. Move to
allowing device removal, as per all other profiles, within
profile limits.

Abstract btrfs-raid profile minimum device count & maximum
device missing info and use the former through-out the fencing
code. Adapt all related tests to the newly uniform error messages
that result from hitting the remaining revised limitations.

These code changes are also intended to ease our adoption of
raid1c3 & raid1c4 profiles. And form the initial awareness of
these newer btrfs-raid profiles.
@phillxnet phillxnet mentioned this issue Feb 23, 2023
Merged
phillxnet added a commit that referenced this issue Feb 25, 2023
@phillxnet
Merge pull request #2500 from phillxnet/2385_Revise_draconian_raid0_d…
f397bc9 
…isk_removal_restriction

Remove raid0 dev restriction & tidy pool dev fencing code #2385
@phillxnet
Copy link
Member Author

Closing as:
Fixed by #2500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
First Stable Poetry build
Development

No branches or pull requests
1 participant
@phillxnet