Fix DataTables error on AFP shares view #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was being caused by the "no shares" table having the data-table class. Also fix the appearance of the same section on the sftp page to look identical.
This fixes issues rockstor#813 and rockstor#1438, where adding a new share with disabled service resulted in an error. The new behaviour is to automatically start the service upon adding an AFP share.
|
This now fixes the other issue and performs a systemctl |
|
@schakrava Good idea. My IDE parser no longer accepts python 2, so it's marking these as invalid syntax. Looks like it's mostly "Exception, e" that it's complaining about though. |
|
Hey @sfranzen Thanks for finding out the issue and fixing it. Very good catch. I didn't notice it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by the table displayed in the absence of existing shares being classed
data-tableand stopped the view from loading fully. Partial fix of #1438, which also involves #813.