Disabling gulp on Rockstor buildout

[MFlyer]

Hi @schakrava ,
had some issues with gulp while on buildout, I think we can remove it from Rockstor buildout and have it only on git repo for contributors

M.

[schakrava]

Hey @MFlyer nice to see you again :)

What's the issue? and what do you mean by having it on git repo for contributors?

[MFlyer]

Ciao @schakrava :)
while having a buildout over my dev env VM it failed because of linting errors, but having gulp linting on git repo it doesn't fail with errors.
Had a full rewrite of my VM - I had some tests so I supposed those linting errors because of this -, but probably on dev env VM (and "normal" Rockstor too) we can fail because we update gulp on every buildout/init script
M.

P.S.: will have my time and finish Rockstor Custom tasks + others, it's a promise 😉
P.S.2: new job is really exciting 😃

[phillxnet]

@MFlyer I've just got this with a clean build of master from a few days ago:

[11:49:00] Using gulpfile /opt/rockstor-dev/gulpfile.js
[11:49:00] Starting 'lint'...
[11:49:02] 
/opt/rockstor-dev/src/rockstor/storageadmin/static/storageadmin/js/views/add_pool.js
  251:1  error  Expected indentation of 16 spaces but found 12  indent
  252:1  error  Expected indentation of 20 spaces but found 16  indent
  253:1  error  Expected indentation of 20 spaces but found 16  indent
  254:1  error  Expected indentation of 24 spaces but found 20  indent
  255:1  error  Expected indentation of 24 spaces but found 20  indent
  256:1  error  Expected indentation of 20 spaces but found 16  indent
  257:1  error  Expected indentation of 24 spaces but found 20  indent
  258:1  error  Expected indentation of 24 spaces but found 20  indent
  259:1  error  Expected indentation of 20 spaces but found 16  indent
  260:1  error  Expected indentation of 16 spaces but found 12  indent
  310:1  error  Expected indentation of 12 spaces but found 8   indent
  311:1  error  Expected indentation of 16 spaces but found 12  indent
  312:1  error  Expected indentation of 16 spaces but found 12  indent
  313:1  error  Expected indentation of 16 spaces but found 12  indent
  314:1  error  Expected indentation of 12 spaces but found 8   indent
  315:1  error  Expected indentation of 12 spaces but found 8   indent
  316:1  error  Expected indentation of 16 spaces but found 12  indent
  317:1  error  Expected indentation of 12 spaces but found 8   indent

/opt/rockstor-dev/src/rockstor/storageadmin/static/storageadmin/js/views/add_scheduled_task.js
   89:1  error  Expected indentation of 12 spaces but found 8      indent
   90:1  error  Expected indentation of 12 spaces but found 8      indent
   91:1  error  Expected indentation of 12 spaces but found 8      indent
   92:1  error  Expected indentation of 12 spaces but found 8      indent
   93:1  error  Expected indentation of 12 spaces but found 8      indent
   94:1  error  Expected indentation of 12 spaces but found 8      indent
   95:1  error  Expected indentation of 12 spaces but found 8      indent
   96:1  error  Expected indentation of 12 spaces but found 8      indent
   97:1  error  Expected indentation of 12 spaces but found 8      indent
   98:1  error  Expected indentation of 12 spaces but found 8      indent
  100:1  error  Expected indentation of 12 spaces but found 8      indent
  101:1  error  Expected indentation of 12 spaces but found 8      indent
  104:1  error  Expected indentation of 12 spaces but found 8      indent
  105:1  error  Expected indentation of 12 spaces but found 8      indent
  106:1  error  Expected indentation of 12 spaces but found 8      indent
  107:1  error  Expected indentation of 12 spaces but found 8      indent
  108:1  error  Expected indentation of 12 spaces but found 8      indent
  109:1  error  Expected indentation of 12 spaces but found 8      indent
  248:1  error  Expected indentation of 20 spaces but found 33     indent
  267:1  error  Expected indentation of 8 spaces but found 2 tabs  indent

/opt/rockstor-dev/src/rockstor/storageadmin/static/storageadmin/js/views/disks.js
  77:1  error  Expected indentation of 8 spaces but found 6  indent

/opt/rockstor-dev/src/rockstor/storageadmin/static/storageadmin/js/views/email.js
  101:55  error  Unnecessary escape character: \-  no-useless-escape
  101:93  error  Unnecessary escape character: \-  no-useless-escape

/opt/rockstor-dev/src/rockstor/storageadmin/static/storageadmin/js/views/luks_disk.js
  76:1  error  Expected indentation of 12 spaces but found 16  indent
  77:1  error  Expected indentation of 12 spaces but found 16  indent

/opt/rockstor-dev/src/rockstor/storageadmin/static/storageadmin/js/views/pools.js
   96:1  error  Expected indentation of 16 spaces but found 21  indent
   97:1  error  Expected indentation of 16 spaces but found 21  indent
   98:1  error  Expected indentation of 16 spaces but found 21  indent
  101:1  error  Expected indentation of 16 spaces but found 25  indent

/opt/rockstor-dev/src/rockstor/storageadmin/static/storageadmin/js/views/scheduled_tasks.js
  60:1  error  Expected indentation of 8 spaces but found 2 tabs   indent
  82:1  error  Expected indentation of 12 spaces but found 3 tabs  indent

/opt/rockstor-dev/src/rockstor/storageadmin/static/storageadmin/js/views/setrole_disks.js
  76:1  error  Expected indentation of 12 spaces but found 16  indent
  77:1  error  Expected indentation of 12 spaces but found 16  indent

/opt/rockstor-dev/src/rockstor/storageadmin/static/storageadmin/js/views/share_details_layout_view.js
  318:1  error  Expected indentation of 20 spaces but found 16  indent

/opt/rockstor-dev/src/rockstor/storageadmin/static/storageadmin/js/views/share_usage_module.js
  168:88  error  Unnecessary escape character: \.  no-useless-escape

/opt/rockstor-dev/src/rockstor/storageadmin/static/storageadmin/js/views/shares.js
   89:1  error  Expected indentation of 4 spaces but found 0       indent
   96:1  error  Expected indentation of 8 spaces but found 2 tabs  indent
   99:1  error  Expected indentation of 8 spaces but found 2 tabs  indent
  146:1  error  Expected indentation of 4 spaces but found 4 tabs  indent

✖ 57 problems (57 errors, 0 warnings)
  54 errors, 0 warnings potentially fixable with the `--fix` option.

[11:49:02] 'lint' errored after 2.25 s
[11:49:02] ESLintError in plugin 'gulp-eslint'
Message:
    Failed with 57 errors
gulp-eslint: Non zero exit code (1) while running command.
While:
  Installing gulp-eslint.
Error: Non zero exit code (1) while running command.

I'm guessing it's the same issue as I've changed non of these files from master.

Build then halts which does seem harsh.

[MFlyer]

Hi @schakrava ,
@phillxnet got same issue and I i think it's only gulp related, cos' not having it with gulp on my git repo (I didn't update gulp on my machine), but only every buildout on dev env VM (our buildout updates gulp to latest on every run)

M.

[MFlyer]

To @schakrava : done linting on js code, last gulp version is strict on indent
npm removed on buildout so we avoid failing init/dev building
@schakrava & @phillxnet can you test this? coding from office, no available dev env, my home notebook failed over audio & video cards :(
Ready to be merged

[MFlyer]

Update: had a new VM and my notebook is back, tested and working @schakrava :)

M.

[MFlyer]

To @schakrava : rebased and ready to be merged
M.

[MFlyer]

Closing this,
PR #1916 by @phillxnet addressing same gulp linting issue! :)
M.