Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the meta tag name #9

Closed
shoaibsharif opened this issue May 31, 2021 · 1 comment
Closed

change the meta tag name #9

shoaibsharif opened this issue May 31, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@shoaibsharif
Copy link

Hi,
First of all, thank you for this npm package. It actually helps me a lot. While I was working on a project, I have noticed it has a tiny issue when I tried to get og:image from head. Upon researching, I have found that you are trying to find 'meta[name="og:image"]' where I think you should find 'meta[property="og:image"]'.

@rocktimsaikia
Copy link
Owner

rocktimsaikia commented Jun 1, 2021

That's a valid issue but some sites do attach the Social image with the name attribute. So we can check for the property attribute first if not present the fallback to the name attribute.

PRs welcome.

@rocktimsaikia rocktimsaikia added the bug Something isn't working label Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants