Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ESLint Warnings #38

Closed
FoggyMtnDrifter opened this issue May 4, 2024 · 0 comments · Fixed by #39
Closed

[BUG] ESLint Warnings #38

FoggyMtnDrifter opened this issue May 4, 2024 · 0 comments · Fixed by #39
Assignees
Labels
priority: low This issue or pull request is of low priority tag: good first issue Good for newcomers type: bug Something isn't working

Comments

@FoggyMtnDrifter
Copy link
Member

To Reproduce

There are currently ESLint warnings for the project. We should resolve those. I have specified the warnings in the "Additional Context" of this issue.

Expected Behavior

Ideally we shouldn't have any ESLint warnings.

Screenshots

No response

Device

Not Applicable

Browser

Not Applicable

Operating System

Not Applicable

Additional Context

/home/runner/work/rockylinux.org/rockylinux.org/app/[locale]/download/components/CloudImage/Table/DataTable.tsx
   90:6   warning  React Hook React.useEffect has a missing dependency: 'table'. Either include it or remove the dependency array                                  react-hooks/exhaustive-deps
   90:7   warning  React Hook React.useEffect has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked  react-hooks/exhaustive-deps
  144:18  warning  Strings not allowed in JSX files: "No results."                                                                                                 react/jsx-no-literals
  157:12  warning  Strings not allowed in JSX files: "Previous"                                                                                                    react/jsx-no-literals
  165:12  warning  Strings not allowed in JSX files: "Next"                                                                                                        react/jsx-no-literals

/home/runner/work/rockylinux.org/rockylinux.org/components/ui/dialog.tsx
  49:35  warning  Strings not allowed in JSX files: "Close"  react/jsx-no-literals

✖ 6 problems (0 errors, 6 warnings)```
@FoggyMtnDrifter FoggyMtnDrifter added type: bug Something isn't working priority: low This issue or pull request is of low priority tag: good first issue Good for newcomers labels May 4, 2024
@FoggyMtnDrifter FoggyMtnDrifter self-assigned this May 4, 2024
@FoggyMtnDrifter FoggyMtnDrifter linked a pull request May 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low This issue or pull request is of low priority tag: good first issue Good for newcomers type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant