Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdis-3.3.0 release tarball errors in setup.py #33

Closed
dol-sen opened this issue Mar 27, 2017 · 3 comments
Closed

xdis-3.3.0 release tarball errors in setup.py #33

dol-sen opened this issue Mar 27, 2017 · 3 comments
Labels

Comments

@dol-sen
Copy link

dol-sen commented Mar 27, 2017

Seems this code was not committed, but was in the release tarball. Looks like a copy/paste error.
You should likely re-release as 3.3.1 with the fixed code.

/usr/bin/python3.5 setup.py build
File "setup.py", line 25
tests_require = tests_require,
^
SyntaxError: keyword argument repeated

"""Setup script for the 'xdis' distribution."""

from pkginfo import
author, author_email,
license, long_description, classifiers,
modname, py_modules, tests_require,
scripts, short_desc, tests_require,
VERSION, web, zip_safe

from setuptools import setup, find_packages
setup(
author = author,
author_email = author_email,
classifiers = classifiers,
description = short_desc,
license = license,
long_description = long_description,
name = modname,
packages = find_packages(),
py_modules = py_modules,
tests_require = setup_requires,
scripts = scripts,
tests_require = tests_require,
url = web,
version = VERSION,
zip_safe = zip_safe)

@rocky
Copy link
Owner

rocky commented Mar 27, 2017

I just downloaded the 3.3.0 tarball and I'm not seeing tests_require repeated.

@dol-sen
Copy link
Author

dol-sen commented Mar 28, 2017

Now this is truly strange... I checked the tarball with archive-manager, opend setup.py and it is correct.
Yet our package manager repeatedly unpacks it with those errors...

It may be a compatibility issue between teh commands you made it with and the command being used by the package manager.

What command do you use to create the tarball? setup.py sdist?
I'll check it out more in the morning

@rocky
Copy link
Owner

rocky commented Mar 28, 2017

Yep, setup sdist. This kind of stuff has happened before on your end. Thing thing that gets me is how you often come across as so confident the problem lies elsewhere than your own code.

@rocky rocky closed this as completed Mar 28, 2017
@rocky rocky added the Invalid label Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants