[HIPIFY] Transformation of declarations with external linkage and shared attribute for IncompleteArrayType (Part 2)

[emankov]

(Part 2) Transformations are needed in cases of further possible assignments of already transfomed "extern" variable. Example:

extern __shared__ uint sRadix1[]; =>  HIP_DYNAMIC_SHARED(unsigned int, sRadix1);  // Part 1, done
uint * sRadix2 = sRadix1; => __attribute__((address_space(3))) uint* sRadix2 = sRadix1; // Part 2

First part of transformation (transformation of declarations with external linkage and shared attribute for IncompleteArrayType) has already done. Second part - all assignments of such "extern" var should be transformed as well.

sRadix2 can't be of type uint* after hipifying. It should be of type __attribute__((address_space(3))) uint* due to the changed type of sRadix1:

#define HIP_DYNAMIC_SHARED(type, var) \
__attribute__((address_space(3))) type* var = \
(__attribute__((address_space(3))) type*)__get_dynamicgroupbaseptr(); \

There might be more complicated situations when this "extern" var is used as a function argument (It is a 3rd part - to be investigated, example is needed).

[emankov]

As long as HIP_DYNAMIC_SHARED macro is changed to:

#define HIP_DYNAMIC_SHARED(type, var) type* var = (type*)__get_dynamicgroupbaseptr();

types transformation is not needed anymore, thus close the issue.