Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIPIFY] hipify-clang's include semantics change based on the existence of -o #26

Closed
ChrisKitching opened this issue Oct 16, 2017 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ChrisKitching
Copy link
Contributor

STR:

  1. Create an empty file called test.h
  2. Create a file called test.cpp containing only #include "test.h"
  3. Run: hipify-clang test.cpp -- -x cuda --cuda-path=<whatever> - works correctly
  4. Run: hipify-clang -o test.hip test.cpp -- -x cuda --cuda-path=<whatever> - works correctly
  5. Run: hipify-clang -o /any/other/directory/test.hip test.cpp -- -x cuda --cuda-path=<whatever> - Fails:
/home/chris/spectral/xcmake/src/../wat.hip.hip:1:10: fatal error: 'test.h' file not found
#include "test.h"
         ^~~~~~~~
1 error generated.
Error while processing /home/chris/spectral/xcmake/src/../wat.hip.hip.

It seems that the output path is being used to resolve includes, and hence relative includes fail if you set an output path in a different directory.

@emankov emankov self-assigned this Oct 16, 2017
@emankov emankov changed the title hipify-clang's include semantics change based on the existence of -o [HIPIFY] hipify-clang's include semantics change based on the existence of -o Oct 16, 2017
@ChrisKitching
Copy link
Contributor Author

ROCm/HIP#210 Should also resolve this. Not sure why github's auto-citation thingy didn't pickup on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants