Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIPIFY] hipify-perl produces incorrect output for kernels that have no input args #33

Closed
mattsinc opened this issue Nov 10, 2017 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@mattsinc
Copy link

I am porting an application that exclusively uses hipMemcpyToSymbol for its kernels. When I run hipify-perl on this, it will happily convert it (except for the threadfence issue I noted in #32). However, when I try to compile the kernel I get the following for each kernel:

hipLaunchKernelGGL((Kernel1), dim3(numTBs), dim3(numThreadsPerBlock), 0, 0, );

This is related to the issue I raised in ROCm/HIP#257 -- currently hipcc requires at least one input arg to correctly compile a kernel, when this is not necessary if MemcpyToSymbol is used. But regardless, it doesn't seem like hipify should add a comma with nothing after it.

Matt

@emankov emankov self-assigned this Nov 11, 2017
emankov referenced this issue in ROCm/HIP Sep 4, 2019
@emankov
Copy link
Collaborator

emankov commented Sep 4, 2019

Fixed by ROCm/HIP#1387

@emankov emankov closed this as completed Sep 4, 2019
@emankov emankov transferred this issue from ROCm/HIP Apr 3, 2020
@emankov emankov added the bug Something isn't working label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants