Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .yaml file extension #76

Closed
vkorobkov opened this issue Oct 18, 2017 · 2 comments
Closed

Support .yaml file extension #76

vkorobkov opened this issue Oct 18, 2017 · 2 comments
Assignees

Comments

@vkorobkov
Copy link
Collaborator

vkorobkov commented Oct 18, 2017

YML files have two valid possible extensions: .yml and .yaml

Currently we do not support .yaml extension and we need to fix it before the public release.

  1. com.github.vkorobkov.jfixtures.config.ConfigLoader
    Should lookup for .conf.yaml first, in case of failure should lookup fpr .conf.yml

  2. com.github.vkorobkov.jfixtures.loader.FixturesLoader#isYml should be fixed:

.endsWith(".yml") || .endsWith(".yaml")

There is an edge case here: if the same fixture exists with both extensions(like users.yaml and users.yml we need to throw an exception with a readable message)

@rodionovsasha
Copy link
Owner

PR #85

@rodionovsasha
Copy link
Owner

merged to master as 1.0.2.6. release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants