Prevent infinite recursion when resolving complex relationships #495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised in #418, when checking the relationships between resources where the relationships are a bit more complex (forward and backward edges between >2 resources), it is possible for
RSpec::Puppet::ManifestMatchers::CreateGeneric#relationship_refs
to get stuck in an infinite recursion loop.This PR fixes that behaviour by adding a simple guard to the recursion to prevent
relationship_refs
from being called on the same resource multiple times.Closes #418