not compatible with fzf.fish

[fredericrous]

Describe the bug
When I use fzf.fish, I am getting extra lines containing "1337;SetKeyLabel=" shown on the attached screenshot

To Reproduce
Steps to reproduce the behavior:

1. fisher install rodrigobdz/fish-apple-touchbar plugin
2. fisher install PatrickF1/fzf.fish
3. Ctrl+R

Expected behavior
I'd like this extra output seen in the screenshot to go away.
Would it be possible that fish-apple-touchbar is not cleaning its output correctly?
Or maybe I didn't configure it correctly (see my config in section Aditionnal Information)

Screenshots

Desktop (please complete the following information):

• OS: Mac Big Sur 11.4
• Fish: 3.3.0
• iTerm2: 3.4.6

Aditionnal Information
I configured fish-apple-touchbar like so:

cat  ~/.config/fish/conf.d/touchbar.fish
__fish_apple_touchbar_bind_key_custom 1 '👈' 'prevd' '-s'
__fish_apple_touchbar_bind_key_custom 2 '🗄 jump' 'cdh' '-s'

[rodrigobdz]

Hi, @fredericrous! Thanks for reporting.

I just looked into it and I found a similar issue with fzf's history containing bind commands. I'm afraid this has to be solved in PatrickF1/fzf.fish.

The extra lines you are seeing containing SetKeyLabel are iTerm2 proprietary escape codes, which provide an interface to customize the Touch Bar. That interface is used in this plugin.

[fredericrous]

Thank you for having looked at this @rodrigobdz ! I'll open an issue there then

[fredericrous]

I found a workaround... Instead of having a file conf.d/touchbar.fish I moved everything into config.fish and the issue disappeared 🤯

[rodrigobdz]

That's interesting. I wonder if all the plugin features still work.

I created conf.d/fish_apple_touchbar.fish a while ago after this announcement, which required plugins to update their file structure.

[kidonng]

@rodrigobdz This is not a bug with either plugin, but OP's own config, see PatrickF1/fzf.fish#184 (comment)