Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goproxytest doesn't support 1.13 cmd/go #84

Closed
josharian opened this issue Oct 7, 2019 · 3 comments
Closed

goproxytest doesn't support 1.13 cmd/go #84

josharian opened this issue Oct 7, 2019 · 3 comments

Comments

@josharian
Copy link

Reproduce:

Run the gohack tests using Go 1.13.

Result:

Lots of test failures. The interesting parts look like:

            go get rsc.io/sampler@v1.2.1: rsc.io@v1.2.1: reading http://127.0.0.1:60141/mod/rsc.io/@v/v1.2.1.info: 500 Internal Server Error

The tests pass with Go 1.12. A cursory glance at the cmd/go source suggests goproxytest changed significantly during Go 1.13, I think for sumdb support in cmd/go.

@mvdan
Copy link
Collaborator

mvdan commented Oct 8, 2019

Interesting... I've been using testscript with goproxytest in a couple of projects, and I've never run into this error with 1.13 or tip. For what it's worth, go test ./... on go-internal master passes for me with 1.13.1.

@mvdan
Copy link
Collaborator

mvdan commented Oct 8, 2019

gohack master did fail on 1.13, but go get github.com/rogpeppe/go-internal@latest fixed it for me by upgrading to v1.4.

@josharian
Copy link
Author

Indeed! Silly me. Thanks, I'll send a PR to gohack.

(Unfortunately, goproxytest still doesn't support .../@v/list urls, but that's a different matter.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants