Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to track previous values on Term details every after update #89

Closed
5 tasks done
RoiJS opened this issue Jul 26, 2021 · 1 comment · Fixed by #90
Closed
5 tasks done

Make it possible to track previous values on Term details every after update #89

RoiJS opened this issue Jul 26, 2021 · 1 comment · Fixed by #90
Assignees
Labels
Internal Changes Any internal updates on the project

Comments

@RoiJS
Copy link
Owner

RoiJS commented Jul 26, 2021

Overview

Today, the user can be able to update the term details assigned to the contract. Any updates on the term details will only take effect on the future statement of accounts but not on the existing ones anymore. This means that the current setup of the term details will no longer match with the existing statement of accounts and this could lead to confusions just in case the system failed to generate a correct statement of account details. So, to make the investigation much easier, I decided to introduce something on the internally so the investigation will be much easier, and this is to introduce the concept of term versioning. If there are any changes applied on the term details assigned to the contract, the system will not perform update on the term but instead it will create a new copy and just keep the old data. Technically, we will need to introduced new table that will keep track on the previous versions of terms assigned to the contract.

TODO

  • Introduce new table called TermVersions.
  • Introduce new DataRepository for the term version
  • Update the logic inside the Update function on ContractControler
  • Make sure to create a new version of the term if there is modifications.
  • Test and verify
@RoiJS
Copy link
Owner Author

RoiJS commented Jul 27, 2021

It is now possible to keep the previous version of terms every after updates. Information are stored on table TermVersions.
Moving this issue to close now.

@RoiJS RoiJS closed this as completed Jul 27, 2021
RoiJS added a commit that referenced this issue Jul 27, 2021
…ck-previous-values-on-Term-details-every-after-update

#89 - Introduced logic that keeps the previous version of the term attached to the contract after any modifications.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Changes Any internal updates on the project
Projects
None yet
1 participant