Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflection guided serialization for rbx_xml #32

Merged
merged 15 commits into from
Apr 25, 2019

Conversation

LPGhatguy
Copy link
Member

@LPGhatguy LPGhatguy commented Apr 20, 2019

Fixes #18, fixes #16, fixes #14.

Converts rbx_xml to depend on rbx_reflection, using its database to drive serialization. This is probably a breaking change, so it might be a good idea to increment the public API before/after this is merged and bundle some more breaking changes in.

Follow up changes:

@LPGhatguy
Copy link
Member Author

Going to push off TODOs into future changes and push to merge this!

@LPGhatguy LPGhatguy marked this pull request as ready for review April 25, 2019 06:16
@LPGhatguy LPGhatguy merged commit 4364711 into master Apr 25, 2019
@LPGhatguy LPGhatguy deleted the reflection-guided-serialization branch April 25, 2019 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smoke name mapping Drive serialization from reflection database rbx_xml name mapping for Fire
1 participant