Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbx_xml name mapping for Fire #14

Closed
LPGhatguy opened this issue Mar 22, 2019 · 3 comments · Fixed by #32
Closed

rbx_xml name mapping for Fire #14

LPGhatguy opened this issue Mar 22, 2019 · 3 comments · Fixed by #32
Labels
type: enhancement New feature or request

Comments

@LPGhatguy
Copy link
Contributor

For Fire, Size serializes as size_xml, and another property I can't remember has a weird name too. Need to add an XML<->Canonical name mapping for Fire.

@LPGhatguy LPGhatguy added the type: enhancement New feature or request label Mar 22, 2019
@Kampfkarren
Copy link
Member

Kampfkarren commented Mar 23, 2019

That means this needs to be changed to be class specific instead of broad property names:

https://github.com/LPGhatguy/rbx-dom/blob/9700f1417e2de7f119fc1701138e6a370e84f744/rbx_xml/src/reflection.rs#L13-L19

@LPGhatguy
Copy link
Contributor Author

I'll probably move it into the rbx_reflection crate eventually, too!

@LPGhatguy
Copy link
Contributor Author

Foundation for this is in now that #28 is around. I'm currently experimenting with porting rbx_xml over to use rbx_reflection under the hood, which will be known as reflection-guided serialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants