Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rbx_reflection API less public #35

Closed
LPGhatguy opened this issue Apr 25, 2019 · 0 comments · Fixed by #38
Closed

Make rbx_reflection API less public #35

LPGhatguy opened this issue Apr 25, 2019 · 0 comments · Fixed by #38
Labels
breaking module: rbx_reflection type: enhancement New feature or request

Comments

@LPGhatguy
Copy link
Contributor

Currently the reflection database is entirely public fields. We should replace those with getters, since everything is read-only anyways.

This would be a good time to fix up the names of these structs as well to mention words like "reflection" and "descriptor" instead of just prefixing everything with Rbx.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking module: rbx_reflection type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tidy up rbx_reflection public interface rojo-rbx/rbx-dom
1 participant
@LPGhatguy