Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small colors amend request #1

Closed
yantakus opened this issue Dec 7, 2016 · 6 comments
Closed

Small colors amend request #1

yantakus opened this issue Dec 7, 2016 · 6 comments

Comments

@yantakus
Copy link

yantakus commented Dec 7, 2016

Hi. Thanks for the amazing theme. Really close to the original one used in JetBrains products.

Here are some small things I'd like to be changed: http://take.ms/Z62D3

The top one is vs-code with your theme and the bottom one is WebStrom with built-in Darcula theme. What do you think?

@rokoroku
Copy link
Owner

rokoroku commented Dec 8, 2016

Sorry, I forgot about JSX syntax.
I'll dig into it soon. :)

@rokoroku
Copy link
Owner

rokoroku commented Dec 9, 2016

Check out v1.0.5

I'm currently not working with JSX, so please give some comments :)

@yantakus
Copy link
Author

yantakus commented Dec 9, 2016

Thanks, it looks much better now. Can we have quotes color the same as the text they wrap?
http://take.ms/xZSWM
It looks quite weird when these colors are different.

Take a look at how it's in WebStrom: http://take.ms/VP1ud

@yantakus
Copy link
Author

yantakus commented Dec 9, 2016

Also, JS template literals look too sloppy with 3 colors:
sagas js - first-agenda 2016-12-09 12-26-41
Compare to the one in webstorm:
sagas js - first-agenda - projects first-agenda 2016-12-09 12-26-58

@rokoroku
Copy link
Owner

rokoroku commented Dec 10, 2016

Good, now I catch the problem, and have worked with real JSX files.

In v1.0.6, the most of wrong string colorizations are fixed.

Since the grammar for colorization is little different, it's difficult to reproduces exactly the same as the theme from WebStorm. (Of course, there are some areas where my personal taste is added.)

But I think you'll be satisfied with this update. :)

@yantakus
Copy link
Author

Yes, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants