Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute graph example #21

Open
sonoro1234 opened this issue Nov 2, 2020 · 3 comments
Open

compute graph example #21

sonoro1234 opened this issue Nov 2, 2020 · 3 comments
Labels
showcase Awesome things created with ImNodes

Comments

@sonoro1234
Copy link
Contributor

sonoro1234 commented Nov 2, 2020

Hi,

I would like to share a compute graph made with ImNodes in LuaJIT-ImGui
All above line https://github.com/sonoro1234/LuaJIT-ImGui/blob/master/examples/cimnodes_r_graph_sample.lua#L378 are the classes needed for the example, below this line there is the user code defining the nodes which can be changed at will.

With the nodes defined in this case this is the result:
compute_r_GIF

@rokups
Copy link
Owner

rokups commented Nov 10, 2020

Since also you tried doing same thing with https://github.com/Nelarius/imnodes, could you share your impressions? Any likes or dislikes in both? Library from @Nelarius seems to be rather complete, at this point it makes me thing my project is pointless waste of time and maybe should be archived.

@sonoro1234
Copy link
Contributor Author

The main advantage of you library compared to Nelarius is that node pins have kind (SlotInfo kind) and Nelarius dont have it. This could be very important in a compute graph with different kind of data (float, matrix, texture)
Also, Nelarius library has a lot of internal complications (altought not seen by the user) that have make appear some subtle bugs and your library is quite simple, so less prone to bugs.
The worst thing in your library is that node ids are taken from node pointer instead of a user provided unique id, it makes things more complex but I could manage (In LuaJIT-ImGui) to take a user provided id and cast it to void* to allow saving and loading the graph.

at this point it makes me thing my project is pointless waste of time and maybe should be archived.

I dont think so. It has some advantages that could be useful depending on use case.

@rokups
Copy link
Owner

rokups commented Nov 10, 2020

That is some inspiring feedback. Thank you 🙏 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
showcase Awesome things created with ImNodes
Projects
None yet
Development

No branches or pull requests

2 participants