Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official Review Retained Colors incorrect if dot color specified #23

Closed
AdamSmasherDerby opened this issue Jan 15, 2018 · 1 comment
Closed

Comments

@AdamSmasherDerby
Copy link
Contributor

When the scoreboard dots are set to red, the "retained review" cross becomes black on red, not red with a transparent background.

I see why this is happening;

  1. The normal OR dot is actually an empty css element with rounded corners inside a div. The dot has a background color set to black, and the div has no background color.
  2. When an OR is retained in this case, the dot element is replaced with two other containers, a vertical stripe and a horizontal one. Each of those containers has a color of black, and they overlap to make a cross. The new "dot retained" element has a background of "none" so it shows the background color.
  3. However, when a color is set for the scoreboard dots, rather than being assigned to the elements inside the div, it is rather assigned to the div itself. That means that when the cross is generated, it's still black, and the transparent background shows the color of the div through on the corners.

What needs to happen is that when a color is assigned for the scoreboard dots, it gets assigned to the crossbars, and to the Dot element, but NOT to the background of the div itself.

@The--Captain
Copy link

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants