Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Symfony 5 and PHP 7 #299

Merged
merged 1 commit into from
May 24, 2022

Conversation

sstok
Copy link
Member

@sstok sstok commented May 15, 2022

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Tickets
License MIT

This adds support for Symfony 6 and PHP 8, and removes support for older Symfony and PHP versions.
Keeping support for these old versions adds to much cost on the maintenance.

@sstok sstok added Feature Symfony Symfony bundle, and validator labels May 15, 2022
@sstok
Copy link
Member Author

sstok commented May 15, 2022

TypeError: Return value of Rollerworks\Component\Search\Loader\ClosureContainer::get() must be an instance of Rollerworks\Component\Search\Loader\mixed, instance of Rollerworks\Component\Search\Input\StringQueryInput returned

Ah yes... returning back to programming after 5 months of absence only to be reminded of the very reason why I took "some" time of...

@sstok
Copy link
Member Author

sstok commented May 17, 2022

The mixed type is only available with PHP 8 and up. I guess it's time to drop support for PHP 7.4.

@sstok sstok added the BC Break label May 17, 2022
@sstok sstok force-pushed the feature/symfony6-support branch 2 times, most recently from 71c1e43 to 284add1 Compare May 24, 2022 07:03
@sstok sstok force-pushed the feature/symfony6-support branch from 284add1 to 5e92618 Compare May 24, 2022 10:10
@sstok sstok changed the title Add support for Symfony 6 Drop support for Symfony 5 and PHP 7 May 24, 2022
Drop support for PHP 7.4 and Symfony 5
@sstok sstok force-pushed the feature/symfony6-support branch from 5e92618 to 7ed89e2 Compare May 24, 2022 11:59
@sstok sstok merged commit 5c1a49d into rollerworks:main May 24, 2022
@sstok sstok deleted the feature/symfony6-support branch May 24, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break Feature Symfony Symfony bundle, and validator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant