chore: enhance full client status tests

[00x-dx]

Overview

Fixes #1259

Checklist

• New and updated code has appropriate documentation
• New and updated code has new and/or updated testing
• Required CI checks are passing
• Visual proof for any user facing features like CLI or documentation updates
• Linked issues closed with keywords

Summary by CodeRabbit

• Tests
  • Improved the structure of TestStatus by organizing assertions into separate subtests for better clarity and testing efficiency. Adjustments were made to accommodate updates in response object structures and validation logic.

[coderabbitai]

Walkthrough

The update to the TestStatus function in node/full_client_test.go enhances the testing coverage by including comprehensive checks for all fields in the Status RPC response. This involves the addition of subtests for "SyncInfo", "ValidatorInfo", and "NodeInfo", with updated assertions that align with the latest response structure and validation logic. This change ensures a more thorough validation of the Status RPC call, adhering to the objectives laid out in the linked issue.

Changes

File	Summary of Changes
node/.../full_client_test.go	Enhanced TestStatus with subtests and updated assertions for "SyncInfo", "ValidatorInfo", and "NodeInfo".

Assessment against linked issues

Objective	Addressed	Explanation
Enhance TestStatus to include checks for all fields in the Status RPC response (#1259)	✅
Add assertions for SyncInfo and ValidatorInfo fields (#1259)	✅

Poem

In the code where tests reside,
A rabbit hopped, its scope widened.
With every leap, assertions aligned,
Bugs shooed away, with peace of mind. 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between d2bfbc3 and e34ed33.

Files selected for processing (1)

• node/full_client_test.go (1 hunks)

Additional comments: 2

node/full_client_test.go (2)

• 900-912: The assertions within the "SyncInfo" subtest correctly validate the earliest and latest block heights, app hashes, block hashes, and the catching up status. This ensures comprehensive testing of the SyncInfo part of the status response.
• 914-917: The "ValidatorInfo" subtest accurately tests the validator's address, public key, and voting power. This is essential for ensuring the integrity of validator information in the status response.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 109de72 and 660c1e8.

Files selected for processing (1)

• node/full_client_test.go (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• node/full_client_test.go

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (109de72) 50.36% compared to head (660c1e8) 50.30%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1504      +/-   ##
==========================================
- Coverage   50.36%   50.30%   -0.06%     
==========================================
  Files          52       52              
  Lines        6731     6731              
==========================================
- Hits         3390     3386       -4     
- Misses       3000     3003       +3     
- Partials      341      342       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.