fix: a plugin error can contains numeric code

rollup · Jun 21, 2023 · 44b7221 · 44b7221
1 parent 33f87b4
commit 44b7221
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/rollup/types.d.ts b/src/rollup/types.d.ts
@@ -35,7 +35,7 @@ export interface RollupLog {
 	meta?: any;
 	names?: string[];
 	plugin?: string;
-	pluginCode?: string;
+	pluginCode?: unknown;
 	pos?: number;
 	reexporter?: string;
 	stack?: string;

diff --git a/src/utils/logs.ts b/src/utils/logs.ts
@@ -783,12 +783,16 @@ export function logParseError(error: Error, moduleId: string): RollupLog {
 }
 
 export function logPluginError(
-	error: RollupLog,
+	error: Omit<RollupLog, 'code'> & { code?: unknown },
 	plugin: string,
 	{ hook, id }: { hook?: string; id?: string } = {}
-): RollupLog {
-	if (error.code && !error.code.startsWith('PLUGIN_') && !error.pluginCode) {
-		error.pluginCode = error.code;
+) {
+	const code = error.code;
+	if (
+		!error.pluginCode &&
+		((typeof code === 'string' && !code.startsWith('PLUGIN_')) || code != null)
+	) {
+		error.pluginCode = code;
 	}
 	error.code = PLUGIN_ERROR;
 	error.plugin = plugin;
@@ -798,7 +802,7 @@ export function logPluginError(
 	if (id) {
 		error.id = id;
 	}
-	return error;
+	return error as RollupLog;
 }
 
 export function logShimmedExport(id: string, binding: string): RollupLog {