Print timestamps on "END" events. #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it was not clear when work had been completed. This sets clearer expectations for someone monitoring the watcher output as to when they can expect their code to have updated.
evocateur
suggested changes
Sep 15, 2017
bin/src/run/watch.js
Outdated
| @@ -76,7 +76,10 @@ export default function watch(configFile, configs, command, silent) { | |||
| break; | |||
|
|
|||
| case 'END': | |||
| if ( !silent && isTTY ) stderr( `\nwaiting for changes...` ); | |||
| if ( !silent && isTTY ) { | |||
| stderr( `\nfinished at ${new Date()}` ); | |||
There was a problem hiding this comment.
The default Date format is rather ...quaint?
$ node -p "new Date().toString()"
Fri Sep 15 2017 15:13:26 GMT-0700 (PDT)Why does this have to be across multiple lines, anyway? [YYYY-MM-DD HH:MM:SS] waiting for changes... seems more than sufficient. date-time looks like a good library for the formatting.
There was a problem hiding this comment.
I moved the timestamp to the "waiting" line and reformatted it.
|
great idea, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was not clear when work had been completed. This sets clearer expectations for someone monitoring the watcher output as to when they can expect their code to have updated.