Fix uninitialized child nodes for conditional expressions #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch + great PR 🎉 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1719.
Problem: Dead branch nodes of conditional expressions were not initialized. i.e. when condition test is known to be true, test node is not initialized.
Fix: Initialize all children of conditional expressions similar to how it's done for if statements.
Test: Check unit test, it fails before this fix.
Another approach would be to remove pruned nodes in logical expressions. E.g.
true || foo()would be pruned totrue,false && foo()would be pruned tofalse.