Lint test configs on commit

[lukastaegert]

This PR contains:

• bugfix
• feature
• refactor
• tests
• documentation
• metadata

Breaking Changes?

• yes
• no

If yes, please describe the breakage.

Please Describe Your Changes

This will lint JavaScript test files on commit via lint-staged the same way it is done for TypeScript files.

[guybedford]

I'm +1 to this in concept but I worry a little about the performance impact of this. Running on Windows the commit hook already overflows my memory in MINGW and result in me having to restart my terminal everytime I commit to Rollup. I know this is a very specific issue on a flakey system, but worth noting.

Is there no way to filter this hook to just apply to those files changed by the commit itself? Surely that is possible given the commit hook knows this information (calling git status or something?).

[lukastaegert]

Is there no way to filter this hook to just apply to those files changed by the commit itself? Surely that is possible given the commit hook knows this information (calling git status or something?).

In fact that is exactly what lint-staged does. It takes only the staged files, looks if there is a hook configured and only runs those files through the appropriate prettier/linting hooks. Thus if you limit the scope of your commits, there should not be issues.

[guybedford]

Ok sure, sounds good then.