Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct handling for retraced namespace variables #2420

Merged
merged 3 commits into from
Aug 25, 2018

Conversation

guybedford
Copy link
Contributor

@guybedford guybedford commented Aug 24, 2018

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevent issue numbers:
Resolves #2413

Description

Fix to ensure that the tracing done through namespaces gets all the same treatment as normal tracing, checking chunking boundaries and included status.

more stable as even chokidar sometimes triggers twice
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@lukastaegert
Copy link
Member

I added a commit to

  • Fix the hashes in the chunking-form test
  • Make sure the error messages for chunking-form tests include both filename and content
  • Set the test that was flaky in Node 6 to require at least Node 8. The error seems to be thrown be acorn when parsing a function overriding a var. Not sure why this sometimes fails and sometimes not.
  • Make the watch events test more stable by allowing the event to be triggered more than once in the chokidar case as well. Seems chokidar is not that much better after all.

@guybedford
Copy link
Contributor Author

Nice, thanks @lukastaegert for those fixes.

@guybedford guybedford merged commit c8873f5 into master Aug 25, 2018
@guybedford guybedford deleted the internal-namespace-reexport branch August 25, 2018 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malformed entry point & missing export in chunk when code splitting
2 participants