Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle conditional breaks in do-while loops with unconditional return #3180

Merged
merged 2 commits into from Oct 20, 2019

Conversation

@codecov
Copy link

codecov bot commented Oct 20, 2019

Codecov Report

Merging #3180 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3180      +/-   ##
==========================================
- Coverage   90.19%   90.19%   -0.01%     
==========================================
  Files         165      165              
  Lines        5907     5905       -2     
  Branches     1799     1797       -2     
==========================================
- Hits         5328     5326       -2     
  Misses        350      350              
  Partials      229      229
Impacted Files Coverage Δ
src/ast/nodes/DoWhileStatement.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06fb16a...63f56d7. Read the comment docs.

@lukastaegert lukastaegert merged commit 24063a6 into master Oct 20, 2019
9 checks passed
@lukastaegert lukastaegert deleted the conditional-break-do-while branch Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant