Do not expose synthetic namespace export in entries and namespaces #4364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Previously, the synthetic namespace export (i.e. "foo" when a module has
syntheticNamedExports: "foo"
) was hidden in entry points but exposed if it was not an actual export of the entry but part of anexport * from
namespace reexport.This PR fixes this by requiring synthetic named exports to be explicit exports and reexports on the one hand and making sure they are not exposed even in reexport scenarios.
I hope this scenario was sufficiently edge case to not break things, but it is actually a problem when creating proxy modules that expose all exports of another module (but should not expose the synthetic namespace).