Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: tsc did not build #4471

Merged
merged 1 commit into from Apr 23, 2022
Merged

Fix: tsc did not build #4471

merged 1 commit into from Apr 23, 2022

Conversation

frank-dspeed
Copy link
Contributor

@frank-dspeed frank-dspeed commented Apr 22, 2022

tsc Version 4.7.0-dev.20220305

cli/run/loadConfigFile.ts:114:4 - error TS2722: Cannot invoke an object which is possibly 'undefined'.

114    defaultLoader(module, requiredFileName);
       ~~~~~~~~~~~~~

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Newer Typescript versions will error on build i marked that this includes tests as running typescript nightly already is the test.

cli/run/loadConfigFile.ts:114:4 - error TS2722: Cannot invoke an object which is possibly 'undefined'.

114    defaultLoader(module, requiredFileName);
       ~~~~~~~~~~~~~
@codecov
Copy link

@codecov codecov bot commented Apr 22, 2022

Codecov Report

Merging #4471 (5b27b33) into master (030c56f) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #4471      +/-   ##
==========================================
- Coverage   98.77%   98.75%   -0.02%     
==========================================
  Files         205      205              
  Lines        7326     7327       +1     
  Branches     2079     2080       +1     
==========================================
  Hits         7236     7236              
  Misses         33       33              
- Partials       57       58       +1     
Impacted Files Coverage Δ
cli/run/loadConfigFile.ts 94.33% <50.00%> (-1.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 030c56f...5b27b33. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Well, if we mean "tested" we mean an automated test that runs automatically, not something that you can run on your machine manually, but I guess this is not much of a logic change and will not have much impact.

@lukastaegert lukastaegert merged commit 4b6627f into rollup:master Apr 23, 2022
10 of 12 checks passed
@frank-dspeed
Copy link
Contributor Author

@frank-dspeed frank-dspeed commented Apr 23, 2022

@lukastaegert it has impact at last for me it lets me build the source code with the current version of the language it is coded in 👍🏻

@frank-dspeed
Copy link
Contributor Author

@frank-dspeed frank-dspeed commented Apr 23, 2022

i guess i am even the only one who uses the plugins with its types as they are all broken but the updates with @shellescape are to hard i need near weekly iterations to keep something compatible to current and latest. Only because you try to publish isomorphic packages. Rollup + Plugins could be easy delivered as CJS only . The browser version can be and should be esm but the nodejs version should be CJS

@frank-dspeed frank-dspeed deleted the patch-2 branch Apr 23, 2022
@lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Apr 23, 2022

running typescript nightly

with the current version of the language

Admittedly, your understanding of what "current" is differs from mine as I would also require it to be stable and publicly released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants