Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow symlinks #450

Merged
merged 9 commits into from
Dec 20, 2016
Merged

follow symlinks #450

merged 9 commits into from
Dec 20, 2016

Conversation

Rich-Harris
Copy link
Contributor

PR for #447. Note that this only works for the default resolver – plugins would have to implement similar logic separately.

@eventualbuddha
Copy link
Contributor

Seems sane 👍

@Rich-Harris
Copy link
Contributor Author

It fails on Windows, or at least the tests do. Presumably symlinks are handled different there? @TrySound any ideas on what we need to do to get this test to pass?

@eventualbuddha
Copy link
Contributor

I can look into it if you give me Appveyor access for rollup, @Rich-Harris.

@Rich-Harris
Copy link
Contributor Author

@eventualbuddha can you send me the email address associated with your appveyor account? thanks

@leeyeh
Copy link

leeyeh commented Apr 12, 2016

Any progress here?

@tivac
Copy link
Contributor

tivac commented Apr 12, 2016

I wonder if the windows builds are failing due to git on windows not being able to create symlinks on checkout?

I ran into this recently 😞

@mmolhoek
Copy link

Any progress here? waiting for this one to be fixed, so #447 can be merged, so ionic 2 will handle linked node_modules correctly

@talltyler
Copy link

I personally feel like supporting non-windows environments is better than supporting nothing.
It would be great to get this working.

@quantizor
Copy link

Wholeheartedly agree with @talltyler - would be awesome to get this in.

@Rich-Harris Rich-Harris merged commit a804033 into master Dec 20, 2016
@Rich-Harris Rich-Harris deleted the gh-447 branch December 20, 2016 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants