-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct import.meta.url slashes on Windows #4693
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#import-meta-windows or load it into the REPL: |
c78a627
to
7bfb73f
Compare
Codecov Report
@@ Coverage Diff @@
## master #4693 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 215 215
Lines 7574 7574
Branches 2098 2098
=======================================
Hits 7500 7500
Misses 24 24
Partials 50 50
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
7bfb73f
to
8d31c1e
Compare
a7c3b46
to
bd2cd19
Compare
This PR has been released as part of rollup@3.2.4. You can test it via |
Windows build should be fixed by rollup/rollup#4693 Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Ensure that backslashes are converted to slashes when preserving modules. Ensure that filenames are properly escaped when using
import.meta.url
.