-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set a correct node location for static blocks #4898
Conversation
7faecfb
to
83a22fa
Compare
Codecov Report
@@ Coverage Diff @@
## master #4898 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 221 221
Lines 8025 8026 +1
Branches 2209 2209
=======================================
+ Hits 7946 7947 +1
Misses 26 26
Partials 53 53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install TrickyPi/rollup#fix/4895 or load it into the REPL: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
One thing to note: Could you use findFirstOccurrenceOutsideComment
instead of indexOf
? Because otherwise, this might happen:
Oh, I didn't take this into account, thanks for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 👍
This PR has been released as part of rollup@3.19.1. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #4895
Description