Correctly handling __proto__ export as module object key #5313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5313 +/- ##
==========================================
- Coverage 98.82% 98.81% -0.02%
==========================================
Files 232 232
Lines 8973 8981 +8
Branches 2338 2341 +3
==========================================
+ Hits 8868 8875 +7
Misses 46 46
- Partials 59 60 +1 ☔ View full report in Codecov by Sentry. |
|
@lukastaegert ready to merge. sorry for wasting too much time to deal with existing tests with hash... |
|
BTW you can use |
|
@lukastaegert Under your patient guidance, the heavy maintenance work suddenly became enjoyable! |
lukastaegert
approved these changes
Jan 4, 2024
|
This PR has been released as part of rollup@4.9.3. You can test it via |
yyx990803
added a commit
to vuejs/core
that referenced
this pull request
Feb 5, 2024
4.9.3 introduced a regression in rollup/rollup#5313 which changes the `export * from` codegen and breaks Node.js' re-export detection.
wangdaoo
pushed a commit
to wangdaoo/core
that referenced
this pull request
May 30, 2024
4.9.3 introduced a regression in rollup/rollup#5313 which changes the `export * from` codegen and breaks Node.js' re-export detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
https://rollupjs.org/repl/?version=4.9.1&shareable=JTdCJTIyZXhhbXBsZSUyMiUzQW51bGwlMkMlMjJtb2R1bGVzJTIyJTNBJTVCJTdCJTIyY29kZSUyMiUzQSUyMmltcG9ydCUyMColMjBhcyUyMHglMjBmcm9tJTIwJy4lMkZ4JyUzQiU1Q25jb25zb2xlLmxvZyh4KSUzQiUyMiUyQyUyMmlzRW50cnklMjIlM0F0cnVlJTJDJTIybmFtZSUyMiUzQSUyMm1haW4uanMlMjIlN0QlMkMlN0IlMjJjb2RlJTIyJTNBJTIyZXhwb3J0JTIwY29uc3QlMjBfX3Byb3RvX18lMjAlM0QlMjAwJTNCJTIyJTJDJTIyaXNFbnRyeSUyMiUzQWZhbHNlJTJDJTIybmFtZSUyMiUzQSUyMnguanMlMjIlN0QlNUQlMkMlMjJvcHRpb25zJTIyJTNBJTdCJTIyb3V0cHV0JTIyJTNBJTdCJTIyZm9ybWF0JTIyJTNBJTIyZXMlMjIlN0QlMkMlMjJ0cmVlc2hha2UlMjIlM0F0cnVlJTdEJTdE
The PR generate
["__proto__"]:instead of__proto__:. It can also be written byget __proto__ ()instead, if that would be better. All formats have no__proto__related problem now.