Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement features needed by Esperanto #66

Merged
merged 17 commits into from
Aug 13, 2015
Merged

Conversation

Rich-Harris
Copy link
Contributor

Esperanto is continuing to rack up issues, but it doesn't make sense to maintain two projects doing basically the same thing. I'm planning to remove all the bundling logic from Esperanto and just use Rollup instead. Before that's possible, we need to reach feature parity (and fix some bugs exposed by Esperanto):

  • replace exports.default with exports['default']
  • include imports and exports in exposed bundle object
  • prevent module from importing itself
  • fix typo with AMD module IDs (['myModule'] -> 'myModule')
  • make 'use strict' optional (options.useStrict = false)
  • support banner and footer options
  • fix various bugs, yet to catalogue

@Victorystick
Copy link
Contributor

By "remove all bundling logic from Esperanto", what do you intend the main use case for Esperanto to be?

@Rich-Harris
Copy link
Contributor Author

Ultimately, it doesn't really need to exist at all. The bundling has been superseded by Rollup, and the one-to-one conversion can be done by Babel (Esperanto is faster, because it does less, but the reality is most people using ES6 modules are probably using other ES6 features anyway, so would need Babel regardless). But enough people depend on Esperanto that I'd prefer not to completely shut off support – this is just a way of achieving that, by using Rollup internally rather than Esperanto's existing bundler (the API for Esperanto users would be pretty much unaffected).

@Rich-Harris
Copy link
Contributor Author

@Victorystick how far along do you reckon #71 is? We have merge conflicts unfortunately... trying to work out whether it's better to merge this, or wait for that. I've opened a new bundle-scopes branch based off of yours which resolves those conflicts, in case that's useful

@Victorystick
Copy link
Contributor

I'm officially on vacation, and probably won't be able to get as much work done this week as I would like. I think it might be best to merge what you've got, and let me continue as soon as I can.

Your work on fixing the current set of merge conflicts is much appreciated. 😃 Do you see how I intend for BundleScope to work?

Rich-Harris added a commit that referenced this pull request Aug 13, 2015
Implement features needed by Esperanto
@Rich-Harris Rich-Harris merged commit f9ea94c into master Aug 13, 2015
@Rich-Harris Rich-Harris deleted the esperanto-friendly branch August 13, 2015 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants