Bundle scopes #71
Closed
Bundle scopes #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Victorystick
force-pushed
the
bundle-scopes
branch
from
1c34049
to
ea7477f
Compare
Pass `shorthand-properties`.
Breaks a few tests to pass some others. * Breaks `form/multiple-exports` * Passes `function/export-from-renamed`
Statement has some properties that are plain string names. These must be changed to use structured Names or references.
This was referenced Aug 16, 2015
Merged
|
This has gotten more complex than it should, and diverged too far from master. I'm gonna take the lessons I've learned and try do to something similar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress...
Use a BundleScope which keeps track of all top-level variables in use by a bundle, and deconflicts them all, once and for all. Each module has a ModuleScope that links its variables to those in the BundleScope.