Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes not initialized if view created from Java #16

Closed
xxdavid opened this issue Jan 25, 2017 · 2 comments
Closed

Attributes not initialized if view created from Java #16

xxdavid opened this issue Jan 25, 2017 · 2 comments
Assignees
Labels

Comments

@xxdavid
Copy link

xxdavid commented Jan 25, 2017

If you use libraries like Anko or Anvil, you create your views from Java, not XML. Often there's only the Context contructor used, so there are no attrs passed. In that case PageIndicatorView calls init(null) and there's a condition in initAttributes() that won't initialize the attributes. But I don't think that's what you want. I think it should use the default attributes even if there are no passed.

Thank you for this library btw!

@romandanylyk
Copy link
Owner

Thanks for noticing, fixed in new version.

@xxdavid
Copy link
Author

xxdavid commented Jan 27, 2017

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants