Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime exception with NEST 5.x #4

Closed
ssg opened this issue Mar 24, 2017 · 3 comments
Closed

Runtime exception with NEST 5.x #4

ssg opened this issue Mar 24, 2017 · 3 comments

Comments

@ssg
Copy link

ssg commented Mar 24, 2017

When using NEST 5.x clients, ProfiledElasticClient constructor throws the exception:

System.MissingMethodException: 'Method not found: 'Void Nest.ElasticClient..ctor(Nest.IConnectionSettingsValues, Elasticsearch.Net.Connection.IConnection, Nest.INestSerializer, Elasticsearch.Net.Connection.ITransport)'.'
at StackExchange.Profiling.Elasticsearch.ProfiledElasticClient..ctor(ConnectionSettings configuration)

Because it's a runtime exception, it can lead to bugs which can be discovered very late in the development process.

Suggestion: Put a version block in NuGet manifest that prevents it from being installed on NEST 5.x projects until the actual issue is addressed.

@romansp
Copy link
Owner

romansp commented Mar 25, 2017

Hi, @ssg, thanks for the report and provided suggestion!

Unfortunately, I don't currently use this plugin myself anymore, but willing to resolve any existing issues.

Going to apply required changes to support NEST 1.x, 2.x and 5.x, and maybe brand new MiniProfiler v4.

Expect update soon.

@romansp
Copy link
Owner

romansp commented Mar 25, 2017

@ssg, I've made required changes to support NEST 1.x, 2.x and 5.x. To keep SemVer compatibility, several packages were pushed to NuGet.

So, MiniProfiler.Elasticsearch dependencies are following now:

  • 3.x depends on NEST (>= 1.0.0 && < 2.0.0)
  • 4.x depends on NEST (>= 2.0.0 && < 3.0.0)
  • 5.x depends on NEST (>= 5.0.0 && < 6.0.0)

@ssg
Copy link
Author

ssg commented Mar 25, 2017

Great news (and so quick too), thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants