Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use listing.setArt #2

Closed
MartijnKaijser opened this issue Nov 21, 2015 · 3 comments
Closed

Use listing.setArt #2

MartijnKaijser opened this issue Nov 21, 2015 · 3 comments

Comments

@MartijnKaijser
Copy link

.setArt({ 'thumb': iconimage, 'banner' : os.path.join(artfolder,'banner.png'), 'fanart': os.path.join(addonfolder,'fanart.jpg') })
liz.setPath(u)

As example code pulled from other addon

@romanvm
Copy link
Owner

romanvm commented Nov 22, 2015

Honestly, I'm not sure about this. This is a very basic example and is not supposed to cover all bases. Thumbnail and fanart images are enough for starters (especially considering the fact that the default Confulence skin simply doesn't support additional art), and if a person develops a plugin advanced enough to display additional art (logos, clearart etc.), I guess, they will read respective documentation for ListItem class after all.

This is not to mention the fact, that setting additional art from plugins seems to be buggy. At least, I wasn't able to make my TV-shows plugin to display additional art from fanart.tv in Aeon-Nox skin, so I gave up trying and implemented only thubms and fanart.

@MartijnKaijser
Copy link
Author

well i know for sure poster, fanart, thumb and banner work for tvshows/episode. Could also be that skins are now doing hacks to not show it as no one did it correctly in the past.

@romanvm
Copy link
Owner

romanvm commented Nov 23, 2015

I've added setArt to the example. Hope, it is enough.

@romanvm romanvm closed this as completed Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants