Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

Remove the use of non-inclusive terms #110

Closed
lodi-g opened this issue Mar 2, 2020 · 1 comment · Fixed by #111
Closed

Remove the use of non-inclusive terms #110

lodi-g opened this issue Mar 2, 2020 · 1 comment · Fixed by #111

Comments

@lodi-g
Copy link

lodi-g commented Mar 2, 2020

There is two non-inclusive words on master branch: 'whitelist' and 'blacklist'.
I think they are not inclusive and should be replaced by 'allow-list' and 'disallow-list' or some equivalent.

https://github.com/facebookexperimental/rome/blob/master/packages/%40romejs/js-compiler/transforms/compile/validation/optimizeImports.ts#L29
https://github.com/facebookexperimental/rome/blob/master/packages/%40romejs/js-parser/xhtmlEntities.ts#L273

Thanks

@sebmck
Copy link
Contributor

sebmck commented Mar 2, 2020

Thanks for flagging! Happy to accept a PR, otherwise I'll get around to it when I can. I've avoided blacklist/whitelist in the configuration in favor of ignore, only etc but this must have slipped through.

We also use the terms master and worker. Unclear if that's a concern since it's not master/slave which is the common problematic case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants