Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

📎 Split playground run function #2619

Closed
Tracked by #2616
NicholasLYang opened this issue May 26, 2022 · 1 comment
Closed
Tracked by #2616

📎 Split playground run function #2619

NicholasLYang opened this issue May 26, 2022 · 1 comment
Labels
A-Tooling Area: our own build, development, and release tooling I-Staff Implementation: should be in charge of a core member of the team task A task, an action that needs to be performed

Comments

@NicholasLYang
Copy link
Contributor

Description

We've amassed quite a few views in the playground. Any more and we'll run into performance as well as usability issues.

One issue that adds to this is the run function in playground/src/lib.rs. It computes the data for all of the views at once. This isn't efficient as only one view is visible at a time. Instead we should have separate functions for each view, that way we can only compute that data.

However, we need to be a little careful, as passing the string from JavaScript to WebAssembly is very inefficient. Perhaps there is a way to persist the string on the Rust side and only update it when necessary. Alternatively, one could prove that this passing of the string is not a big deal (very possible!).

@NicholasLYang NicholasLYang added task A task, an action that needs to be performed A-Tooling Area: our own build, development, and release tooling labels May 26, 2022
@ematipico ematipico added the good first issue Good for newcomers label May 27, 2022
@ematipico ematipico added I-Staff Implementation: should be in charge of a core member of the team and removed good first issue Good for newcomers labels Aug 4, 2022
@github-actions
Copy link

This issue is stale because it has been open 14 days with no activity.

@ematipico ematipico moved this to Done in Rome 2022 Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Tooling Area: our own build, development, and release tooling I-Staff Implementation: should be in charge of a core member of the team task A task, an action that needs to be performed
Projects
Status: Done
Development

No branches or pull requests

2 participants