This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): noConfusingLabels
#4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conaclos
requested review from
leops,
ematipico,
xunilrj and
a team
as code owners
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Conaclos
changed the title
noLabelsnoConfusingLabels
ematipico
approved these changes
Jan 4, 2023
crates/rome_js_analyze/src/analyzers/nursery/no_confusing_labels.rs
Outdated
Show resolved
Hide resolved
ematipico
reviewed
Jan 4, 2023
crates/rome_js_analyze/src/analyzers/nursery/no_confusing_labels.rs
Outdated
Show resolved
Hide resolved
ematipico
approved these changes
Jan 5, 2023
|
This PR is stale because it has been open 14 days with no activity. |
Conaclos
requested review from
ematipico
and removed request for
xunilrj and
leops
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4113
Implements ESLint's rule no-labels.
In contrast to ESLint, we allow labeled loops.
This corresponds to ESLint rule with
allowLoopoption enabled.We do not support the rule's options (
allowLoopandallowSwitch).Test Plan
Include ESLint's unit tests.
Documentation