Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

namespace the styling of .terminal #2

Closed
olmokramer opened this issue May 17, 2015 · 5 comments
Closed

namespace the styling of .terminal #2

olmokramer opened this issue May 17, 2015 · 5 comments

Comments

@olmokramer
Copy link
Contributor

I use both this terminal and terminal-panel, which both have an element with a .terminal class. But now this package is styling the other terminal as well, and it's just a mess. Could you please namespace that rule to select .termrk .terminal instead of just .terminal?
@romgrk
Copy link
Owner

romgrk commented May 20, 2015

My styles are correct, the active rule for that element is .termrk-container .termrk .terminal. The problem comes from atom-terminal-panel.
Anyway, I was expecting that kind of conflict, and I never really liked having that element's class labeled terminal, so I replaced the class by termjs-terminal. 19563f1
I'll notify atom-terminal-panel as well.

@romgrk romgrk closed this as completed May 20, 2015
@romgrk romgrk mentioned this issue May 20, 2015
Closed
@olmokramer
Copy link
Contributor Author

No it's definitely this package. As soon as I toggle the termrk terminal with the termrk:toggle command in the command palette, a <style id="term-style"> element gets added to the top of the <head> with a .terminal and a .terminal-cursor selector in it.

@olmokramer
Copy link
Contributor Author

And I wasn not talking about atom-terminal-panel, but terminal-panel

@romgrk
Copy link
Owner

romgrk commented May 21, 2015

Damn. You're right, I overlooked this one. term.js was injecting its style in head.
8201975 fixes this by pointing Terminal.insertStyle to a -> return function.
I'm adding configuring options for fonts, so I'll publish a patch later today with this in, let me know how it goes.

@olmokramer
Copy link
Contributor Author

Alright! Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romgrk @olmokramer