-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Cover Art wont Update on unmatched game #920
Comments
Additional Context. Here's the payload that I get back for this particular rom {
"id": 817,
"igdb_id": null,
"sgdb_id": null,
"moby_id": null,
"platform_id": 111,
"platform_slug": "gba",
"platform_name": "Game Boy Advance",
"file_name": "Pokemon Altered Emerald (v4.2).gba",
"file_name_no_tags": "Pokemon Altered Emerald",
"file_name_no_ext": "Pokemon Altered Emerald (v4.2)",
"file_extension": "gba",
"file_path": "roms/gba",
"file_size_bytes": 16777216,
"name": "Pokemon Altered Emerald",
"slug": null,
"summary": "",
"first_release_date": 0,
"alternative_names": [],
"genres": [],
"franchises": [],
"collections": [],
"companies": [],
"game_modes": [],
"igdb_metadata": {},
"moby_metadata": {},
"path_cover_s": "gba/Pokemon%20Altered%20Emerald/cover/small.jpeg",
"path_cover_l": "gba/Pokemon%20Altered%20Emerald/cover/big.jpeg",
"has_cover": true,
"url_cover": "",
"revision": "",
"regions": [],
"languages": [],
"tags": [
"v4.2"
],
"multi": false,
"files": [],
"full_path": "roms/gba/Pokemon Altered Emerald (v4.2).gba",
"merged_screenshots": [],
"sibling_roms": [],
"user_saves": [],
"user_states": [],
"user_screenshots": [],
"user_notes": [],
"sort_comparator": "pokemon altered emerald"
}
|
Hi! This is a known issue of how RomM renders the cover art. It's already fixed and will be shipped in the next version! You don't even will need to update the covers, they will appear automatically. |
Awesome. I was just going to jump in to say that I think it was a frontend issue because curling the url built by this guy https://github.com/rommapp/romm/blob/3.2.0/frontend/src/components/Game/Card/Cover.vue#L98-L114 returned the image just fine. And looking through the network tab it seems like it's just not even requesting the image in the first place. Will keep an eye on the releases, thanks! |
RomM version
3.2.0
Describe the bug
I upgraded from 3.1.0-rc.2
After that all of the images for roms not matched with moby games don't have cover art anymore.
Also editing roms by reuploading the cover art doesn't do anything.
Checking the logs and the browser network tab reveals 0 errors or helpful logs.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
not lose my cover art, and also be able to upload new cover art. or at least have some logs showing what happened
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: