Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct commit to use in plugins that add support for PlaceholderAPI #26

Closed
randombyte-developer opened this issue Jul 17, 2017 · 3 comments

Comments

@randombyte-developer
Copy link

randombyte-developer commented Jul 17, 2017

So it might be confusing for developers that don't know jitpack what the line compile "com.github.rojo8399:PlaceholderAPI:master-SNAPSHOT" does.

I just wanted to add support in another plugin for PAPI but looking at the current commits it may be not working with the latest commit of master(SNAPSHOT). So I had to dig to the commit that introduced version 4.0 and use that. I would very really highly recommend you to just add a version tag under the release section of this repo to point to this commit of v4.0. Then the dependency looks like this: com.github.rojo8399:PlaceholderAPI:v4.0. It would make things very easy.

I do this regularly: https://github.com/randombyte-developer/kosp/tags

Edit: 1b6fb7b is right for 4.0?

@Wundero
Copy link
Collaborator

Wundero commented Jul 18, 2017

Nope, that commit is not version 4.0. Version 3.12 is likely what you are looking for if you don't want to work with the breaking changes. 4.0 is the complete rewrite to support more than player, annotation based object-method registration and more nifty stuff. Version 3.12 will be kept on the branch legacy-(3.12) for some time, for documentation and legacy support purposes.

To clarify: version 4.0 was SUPPOSED to be the update adding relational placeholders and forcing a breaking method change. However, a suggestion by dualspiral got me thinking about a more effective system to have more dynamic replacement. As such, I moved the then-existing 4.0 into 3.12 and undid it's breaking change, then completely rewrote the plugin, and called the new version 4.0. (Sorry for the confusion about this).

I will look into release tags for jitpack for both 3.12 and 4.0, and all future versions. Shouldn't be too hard to do so I will likely do it by the release of 4.0.

@randombyte-developer
Copy link
Author

randombyte-developer commented Jul 18, 2017

Ok, thanks. Creating a tag/release is very easy: releases -> new -> pick right commit on right branch -> name the thing(v3.12) -> done!

@Wundero
Copy link
Collaborator

Wundero commented Jul 25, 2017

Tags exist for 3.12, 4.0 and 4.1. Any future versions will also have tags attached to them.

@Wundero Wundero closed this as completed Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants