Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considering dropping HHVM support #103

Closed
ronanguilloux opened this issue Jun 1, 2016 · 6 comments
Closed

Considering dropping HHVM support #103

ronanguilloux opened this issue Jun 1, 2016 · 6 comments
Labels

Comments

@ronanguilloux
Copy link
Owner

Is anyone using HHVM here?

Cf. symfony/symfony#18922

@ronanguilloux ronanguilloux changed the title Considering dropping HHVM Considering dropping HHVM support Jun 1, 2016
@soullivaneuh
Copy link
Contributor

No for my case.

But the code is actually running on HHVM without hack.

Maybe can we keep this and consider dropping it later if we have to do too much hacks and if HHVM will be very less used?

@soullivaneuh
Copy link
Contributor

I also launched a subject for Sonata: sonata-project/dev-kit#126

@ronanguilloux
Copy link
Owner Author

If no energy/interest to support HHVM is found here, we'll consider putting an end to HHVM support, unless any good contribution may put HHVM travis builds into green again.

@soullivaneuh
Copy link
Contributor

You can also leave it on allow failure waiting that.

The fast_finish option would help to get rid of allowed failure jobs for PR status: https://blog.travis-ci.com/2013-11-27-fast-finishing-builds/

@soullivaneuh
Copy link
Contributor

BTW, test itself seems to work: https://travis-ci.org/ronanguilloux/IsoCodes/jobs/133623468#L384

The error come from another thing...

Can you remember me why you put -d error_reporting=16384 option? I don't use it at all on my projects.

soullivaneuh added a commit to soullivaneuh/IsoCodesValidator that referenced this issue Jan 10, 2017
We have to follow IsoCodes configuration.

Ref: ronanguilloux/IsoCodes#103
soullivaneuh added a commit to soullivaneuh/IsoCodesValidator that referenced this issue Jan 10, 2017
We have to follow IsoCodes configuration.

Ref: ronanguilloux/IsoCodes#103
@ronanguilloux
Copy link
Owner Author

Because of : "In September 2017, it was announced that version 3.24 would be the last version of HHVM to officially support PHP, and that HHVM will only support Hack going forward, citing differences and incompatibilities in PHP 7." (Source: https://en.wikipedia.org/wiki/HHVM)
this issue will now be closed.

MaximeLC2 pushed a commit to Vigicorp/IsoCodes that referenced this issue Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants